Save statistics of level attempts #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is cool. |
|
I only had a quick glance, and there's one thing that sticks out to me and this is related to the file format itself: What if you wanted to track more stats in the future? What if you wanted to remove a stat in the future? You have encoded the three stats as an array of numbers, which is order-dependent and you've forever reserved indices 0, 1 and 2 for those stats. I think they should be key-value pairs instead, which would make them order-independent and more flexible. |
Good point. I'll change that. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes save how many times the player completes, timeouts, or falls on a given level.
My motivation was to find out which levels were the toughest for me (the ones with the highest timeouts and falls)
It supports score files without any statistics so you don't need to restart your game progress but it will start adding them to the files as soon as you complete or fail a level. Back up your scores folder before testing this so you can easily revert.